Skip to content

feat(wysiwyg): add search and replace functionality to wysiwyg mode #882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
d3m1d0v wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat(wysiwyg): add search and replace functionality to wysiwyg mode #882

d3m1d0v wants to merge 4 commits into from

Conversation

@d3m1d0v
Copy link
Member

@d3m1d0v d3m1d0v commented Nov 21, 2025 •
edited
Loading

  1. Updated styles for search matches in markup-mode
  2. Updated appearance of search panel:
    • added compact view
    • also react components for search panel moved from src/markup/codemirror/* to src/modules/search
  3. Added search-n-replace functionality to WYSIWYG-mode, same as in markup-mode
    • added Search behavior extension, uses prosemirror-search package
    • uses search components from src/modules/search
    • enabled by default, but can be disabled via props: 
      useMarkdownEditor({
  wysiwygConfig: {
    searchPanel: false,
  },
});

@gravity-ui-bot
Copy link
Contributor

gravity-ui-bot commented Nov 21, 2025

Preview is ready.

@gravity-ui-bot
Copy link
Contributor

gravity-ui-bot commented Nov 21, 2025

Visual Tests Report is ready.

@d3m1d0v d3m1d0v marked this pull request as ready for review November 25, 2025 11:41
@d3m1d0v d3m1d0v requested a review from makhnatkin as a code owner November 25, 2025 11:41
@makhnatkin
Copy link
Collaborator

makhnatkin commented Nov 25, 2025

It seems that scrolling doesn't always occur during replay, I suggest checking this behavior.

makhnatkin
makhnatkin reviewed Nov 25, 2025
View reviewed changes
@makhnatkin makhnatkin self-requested a review December 10, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@makhnatkin makhnatkin makhnatkin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@d3m1d0v @gravity-ui-bot @makhnatkin